[libcxx-commits] [PATCH] D86540: [libcxxabi, libunwind] support running tests in standalone mode

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libunwind/cmake/Modules/HandleOutOfTreeLLVM.cmake:1
+macro(find_llvm_parts)
+    # Rely on llvm-config.
----------------
Instead of copy-pasting this, it should use the one from `libcxx`.

`libunwind`, `libcxxabi` and `libcxx` are all required in the tree at all times. A Standalone build refers to where the root of the CMake invocation is, not whether `libunwind` is actually checked out on its own. Because of this, it should be possible to reuse `HandleOutOfTreeLLVM.cmake` from libcxx instead of duplicating it.


================
Comment at: libunwind/test/CMakeLists.txt:36
+  DEPENDS unwind ${LIBUNWIND_TEST_DEPS}
+  PARAMS "${LIBUNWIND_TEST_PARAMS}")
----------------
Where is this defined?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86540/new/

https://reviews.llvm.org/D86540