[libcxx-commits] [PATCH] D86920: [libcxxabi] Provide options to set compiler/link flags for test programs.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D86920#2249445 <https://reviews.llvm.org/D86920#2249445>, @ldionne wrote:

> We'd like to move away from going through CMake to set test-only variables, as it's not a great mechanism for doing so. Instead, please consider using a custom Lit config file like `libcxx/test/configs/libcxx-trunk-shared.cfg.in`, which allows you to customize how you run the test suite a lot more.

To explain my point, what we're trying to avoid is to go through CMake in order to change specific Lit parameters. It's not a great model if for each Lit-related "customization point" we have, we also need to add a CMake variable and an entry in the `lit.site.cfg.in` file. It leads to bloated and complicated CMake files. Instead, modifying how you run lit directly is both more powerful and simpler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86920/new/

https://reviews.llvm.org/D86920