[libcxx-commits] [PATCH] D90068: [libc++] Perform libc++ CI directly in the pipeline instead of triggering our own pipeline

Mikhail Goncharov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 29 03:39:11 PDT 2020


goncharov added a comment.

In D90068#2351068 <https://reviews.llvm.org/D90068#2351068>, @ldionne wrote:

> As we've discussed before, I would prefer to keep the libc++ CI pipeline separate since it provides a nicer view of everything that has run recently for libc++, without being cluttered by other projects. We're losing this here, but we're gaining proper reporting in Phabricator reviews, which I think is more important.
>
> However, another way we could perhaps achieve proper reporting is if we moved the reporting step that's currently run in the `premerge-checks` pipeline into the `libcxx-ci` pipeline. Would that work? I assume the reporting step isn't strongly tied to the `premerge-checks` pipeline?

I think that it should be possible to modify reporting so it will look closer on the result of libcxx pipeline and keep it separate.
How do you image proper reporting should look like? Would you like to see links to the failed configurations (like we have for windows / linux), e.g. by adding "libcxx C++03" next to the build or something else? Note that I have not implemented parsing of unit test results yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90068/new/

https://reviews.llvm.org/D90068



More information about the libcxx-commits mailing list