[libcxx-commits] [PATCH] D90111: Partially implement C++20's P1020/P1973.

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added a comment.

I'm personally fine taking small bits of a paper.
I would rather it than have a full implementation get stuck in review.

This patch LGTM apart from the negative compilation tests. I suspect those can be SFINAE tests instead.



================
Comment at: libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.create/make_unique_for_overwrite.array2.compile.verify.cpp:12
+int main(int, char**) {
+  auto up2 = std::make_unique_for_overwrite<int[]>(
+      10, 20, 30,
----------------
Can we not write positive compilation tests for this? Using things like `is_invocable`?

Negative compilation tests should be the last resort.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90111/new/

https://reviews.llvm.org/D90111