[libcxx-commits] [PATCH] D90228: [libcxx] Don't truncate intermediates to wchar_t when widening

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/include/__locale:1410
             for (const char16_t* __p = __buf; __p < __bn; ++__p, ++__s)
-                *__s = (wchar_t)*__p;
+                *__s = *__p;
             __nb = __nn;
----------------
ldionne wrote:
> Do you know why this was added in the first place? Did you try this out on non-windows systems without the cast?
Not sure why it was there; it's been present since the initial libc++ commit. On linux at least, this change makes no difference in `check-cxx`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90228/new/

https://reviews.llvm.org/D90228