[libcxx-commits] [PATCH] D89041: [libc++] Include <__config_site> from <__config>

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D89041#2348645 <https://reviews.llvm.org/D89041#2348645>, @ldionne wrote:

> In D89041#2348643 <https://reviews.llvm.org/D89041#2348643>, @ldionne wrote:
>
>> @mstorsjo  Can you please confirm whether 529ac33197f6408952ae995075ac5e2dc5287e81 <https://reviews.llvm.org/rG529ac33197f6408952ae995075ac5e2dc5287e81> resolves your issues?
>
> Also, please note that you'll need to pass the path to where the libc++ headers are *installed*, not just `libcxx/include`. If that's what you did previously, then this change is nicely preventing you from using mis-configured libc++ headers.

That's indeed what I've been doing so far. When building things entirely from scratch, I can't build libcxx before I've built libcxxabi, and now libcxxabi can't make do with the out-of-the-box headers from libcxx either. And I'm not alone in using such a bootstrap procedure, https://reviews.llvm.org/D89518 also tries to document how to do such a setup.

But maybe it's possible to run cmake on libcxx even though libcxxabi isn't built yet? In that case, I'd have to first configure libcxx (even though it can't be built yet due to missing libcxxabi) just to get proper "installed" libcxx headers, so that I can build libcxxabi, so I then can build libcxx. I'll see if I can make that work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89041/new/

https://reviews.llvm.org/D89041