[libcxx-commits] [PATCH] D89041: [libc++] Include <__config_site> from <__config>

[Ye Luo via Phabricator via libcxx-commits]

ye-luo added a comment.

In D89041#2345115 <https://reviews.llvm.org/D89041#2345115>, @jhuber6 wrote:

> In D89041#2345055 <https://reviews.llvm.org/D89041#2345055>, @ldionne wrote:
>
>> In D89041#2345002 <https://reviews.llvm.org/D89041#2345002>, @ye-luo wrote:
>>
>>> Fails at make install.
>>>
>>> CMake Error at projects/libcxx/include/cmake_install.cmake:753 (file):
>>>
>>>   file INSTALL cannot find
>>>   "/scratch/opt/llvm-clang/build_mirror_offload_nightly/projects/libcxx/__config_site":
>>>   No such file or directory.
>>
>> This change is surprisingly tricky to land. Thanks for the heads up.
>>
>> Should be fixed in
>>
>>   commit b5aa67446e01bd277727b05710a42e69ac41e74b
>>   Author: Louis Dionne <ldionne at apple.com>
>>   Date:   Wed Oct 21 12:53:24 2020 -0400
>>   
>>       [libc++] Fix the installation of libc++ headers since the __config_site change
>
> I'm still getting build errors, from an existing build that worked earlier today, links against libcxx installed previously.
>
>   /home2/3n4/clang/bin/../include/c++/v1/__config:13:10: fatal error: '__config_site' file not found
>   #include <__config_site>
>
> When I try a fresh build using an install script,
>
>   In file included from /home2/3n4/llvm/trunk/llvm-project/compiler-rt/lib/fuzzer/FuzzerCrossOver.cpp:11:
>   /home2/3n4/llvm/trunk/llvm-project/compiler-rt/lib/fuzzer/FuzzerDefs.h:14:10: fatal error: cassert: No such file or directory
>    #include <cassert>

I had to delete the build folder and rebuild from clean. Reusing existing build folder doesn't work for me as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89041/new/

https://reviews.llvm.org/D89041