[libcxx-commits] [PATCH] D89866: [libcxx] [test] Mark bits of fs.enum tests as libcpp specific

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with suggested changes.



================
Comment at: libcxx/test/std/input.output/filesystems/fs.enum/enum.copy_options.pass.cpp:39
+#ifdef _LIBCPP_VERSION
   static_assert(
           E::none == ME(0),
----------------
Please use `LIBCPP_STATIC_ASSERT` instead (it is defined in `test_macros.h`. I'd like to avoid using macros defined in individual stdlibs in the test suite as much as possible.

Also, it would make sense to add a short comment explaining why those are libc++ specific.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89866/new/

https://reviews.llvm.org/D89866