[libcxx-commits] [PATCH] D89040: [libcxx] Allow checking for newlib without using _NEWLIB_VERSION.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I see a couple issues with this:

1. I don't want to add a new CMake option just to detect an underlying libc. We should be able to detect it through other means. Actually why do we even need `_LIBCPP_HAS_NEWLIB_LIBC`?
2. We should have testers for this configuration. Newlib is not currently supported (well.. not officially at least), and we need some kind of testing if we pretend we're supporting it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89040/new/

https://reviews.llvm.org/D89040