[libcxx-commits] [PATCH] D68269: [libc++] Define new/delete in libc++abi only by default

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

Just FWIW, this broke my setup marginally, but it's trivial for me to fix it. (I just hadn't noticed this thread before.) As both libcxxabi and libcxx used to enable it by default, I had resorted to disabling the one in libcxxabi, but keeping the one in libcxx enabled implicitly - as that was the default (I hadn't actually noticed that there were cmake options for controlling it in both, I only knew about the one in libcxxabi). But it's trivial to fix it by explicitly setting the desired state for both of them so that it behaves the same regardless if building the latest release or the latest master version. And I can also switch to enable it in libcxxabi and disable the one in libcxx, to match the new default config.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68269/new/

https://reviews.llvm.org/D68269