[libcxx-commits] [PATCH] D89673: [libcxx] [test] Exclude domain socket tests on windows, like freebsd/darwin

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 19 05:51:01 PDT 2020


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: dexonsmith.

LGTM with the comment rewording applied.



================
Comment at: libcxx/test/support/filesystem_test_helper.h:159
 
   // OS X and FreeBSD doesn't support socket files so we shouldn't even
   // allow tests to call this unguarded.
----------------
`// Some platforms don't support socket files [...]`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89673/new/

https://reviews.llvm.org/D89673



More information about the libcxx-commits mailing list