[libcxx-commits] [PATCH] D89057: Add the C++17 <memory_resource> header (mono-patch)

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added inline comments.


================
Comment at: libcxx/include/__memory_resource_base:14
+
+#ifndef _LIBCPP_CXX03_LANG
+
----------------
Quuxplusone wrote:
> ldionne wrote:
> > This is a C++17 addition, so I would use `#if _LIBCPP_STD_VER > 14`.
> Done. However, I had copied this `#ifndef _LIBCPP_CXX03_LANG` from libc++'s C++17 `<filesystem>`; you might want to make a similar change to `<filesystem>`.
> 
> libc++'s `<string_view>` is not gated on language version at all.
> libc++'s `<string_view>` is not gated on language version at all.

That was a deliberate choice.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89057/new/

https://reviews.llvm.org/D89057