[libcxx-commits] [PATCH] D89535: [libcxx] [test] Ifdef out the time point resolution and range check on windows

Fri Oct 16 05:43:17 PDT 2020

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: dexonsmith.

================
Comment at: libcxx/test/std/input.output/filesystems/fs.filesystem.synopsis/file_time_type.pass.cpp:35

+#ifndef _WIN32
 void test_time_point_resolution_and_range() {
----------------
I would rather you mark the whole test as `// UNSUPPORTED` on Windows. Or split this part of the test into another test, and mark that as unsupported.

I'm trying to get rid of platform specific `#if`s in the test suite when possible. It gives a better overview of what is and isn't supported when running the test suite on various platforms.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89535/new/

https://reviews.llvm.org/D89535