[libcxx-commits] [PATCH] D89534: [libcxx] [test] Mark tests for libcxx specific implementation details with LIBCPP_ONLY()

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: libc++.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.
mstorsjo requested review of this revision.

This matches an existing marking in enum.path.format.pass.cpp.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89534

Files:
  libcxx/test/std/input.output/filesystems/fs.enum/enum.copy_options.pass.cpp
  libcxx/test/std/input.output/filesystems/fs.enum/enum.directory_options.pass.cpp
  libcxx/test/std/input.output/filesystems/fs.enum/enum.file_type.pass.cpp
  libcxx/test/std/input.output/filesystems/fs.enum/enum.perms.pass.cpp


Index: libcxx/test/std/input.output/filesystems/fs.enum/enum.perms.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.enum/enum.perms.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.enum/enum.perms.pass.cpp
@@ -31,7 +31,7 @@
   typedef std::underlying_type<E>::type UT;
   static_assert(!std::is_convertible<E, UT>::value, "");
 
-  static_assert(std::is_same<UT, unsigned >::value, ""); // Implementation detail
+  LIBCPP_ONLY(static_assert(std::is_same<UT, unsigned >::value, "")); // Implementation detail
 
   typedef check_bitmask_type<E, E::group_all, E::owner_all> BitmaskTester;
   assert(BitmaskTester::check());
Index: libcxx/test/std/input.output/filesystems/fs.enum/enum.file_type.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.enum/enum.file_type.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.enum/enum.file_type.pass.cpp
@@ -29,7 +29,7 @@
   typedef std::underlying_type<E>::type UT;
   static_assert(!std::is_convertible<E, UT>::value, "");
 
-  static_assert(std::is_same<UT, signed char>::value, ""); // Implementation detail
+  LIBCPP_ONLY(static_assert(std::is_same<UT, signed char>::value, "")); // Implementation detail
 
   static_assert(
           E::none == ME(0) &&
Index: libcxx/test/std/input.output/filesystems/fs.enum/enum.directory_options.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.enum/enum.directory_options.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.enum/enum.directory_options.pass.cpp
@@ -30,7 +30,7 @@
   // Check that E is a scoped enum by checking for conversions.
   typedef std::underlying_type<E>::type UT;
   static_assert(!std::is_convertible<E, UT>::value, "");
-  static_assert(std::is_same<UT, unsigned char>::value, "");
+  LIBCPP_ONLY(static_assert(std::is_same<UT, unsigned char>::value, ""));
 
   typedef check_bitmask_type<E, E::follow_directory_symlink, E::skip_permission_denied> BitmaskTester;
   assert(BitmaskTester::check());
Index: libcxx/test/std/input.output/filesystems/fs.enum/enum.copy_options.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.enum/enum.copy_options.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.enum/enum.copy_options.pass.cpp
@@ -30,7 +30,7 @@
   typedef std::underlying_type<E>::type UT;
   static_assert(!std::is_convertible<E, UT>::value, "");
 
-  static_assert(std::is_same<UT, unsigned short>::value, ""); // Implementation detail
+  LIBCPP_ONLY(static_assert(std::is_same<UT, unsigned short>::value, "")); // Implementation detail
 
   typedef check_bitmask_type<E, E::skip_existing, E::update_existing> BitmaskTester;
   assert(BitmaskTester::check());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89534.298583.patch
Type: text/x-patch
Size: 2900 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201016/651eccb6/attachment.bin>