[libcxx-commits] [PATCH] D89530: [libcxx] [test] Fix filesystem_test_helper.h to compile for windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added reviewers: ldionne, EricWF, mclow.lists.
Herald added subscribers: dexonsmith, krytarowski.
Herald added a project: libc++.
Herald added a reviewer: libc++.
mstorsjo requested review of this revision.

Use .string() instead of .native() in places where we want to combine paths with std::string.

Convert some methods to take a fs::path as parameter instead of std::string, for cases where they are called with paths as parameters (which can't be implicitly converted to std::string if the path's string_type is wstring).

Ifdef out everything regarding symlinks; they're not entirely straightforward on windows, so leaving handling those on windows as a later concern.

By making this header build successfully for windows, the number of passing tests under test/std/input.output/filesystems increases from 19 to 47.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89530

Files:
  libcxx/test/support/filesystem_test_helper.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89530.298576.patch
Type: text/x-patch
Size: 8343 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201016/c0de99fa/attachment.bin>