[libcxx-commits] [PATCH] D89041: [libc++] Include <__config_site> from <__config>

[Petr Hosek via Phabricator via libcxx-commits]

phosek accepted this revision.
phosek added a comment.

LGTM



================
Comment at: libcxx/CMakeLists.txt:403
 set(LIBCXX_BINARY_DIR  ${CMAKE_CURRENT_BINARY_DIR})
 set(LIBCXX_BINARY_INCLUDE_DIR "${LIBCXX_BINARY_DIR}/include/c++build")
+set(LIBCXX_GENERATED_INCLUDE_DIR "${LIBCXX_BINARY_DIR}/include/c++/v1")
----------------
ldionne wrote:
> phosek wrote:
> > Do we still need this? Could we copy ABI files directly into `LIBCXX_GENERATED_INCLUDE_DIR`?
> I wanted to tackle that as a separate issue after investigating.
> 
> I actually don't see why we need to copy them at all, since the libc++abi headers don't need a generation step.
OK, I was going to suggest having only a single variable called `LIBCXX_INCLUDE_DIR` for simplicity if we don't need this anymore, but that can be done in follow up changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89041/new/

https://reviews.llvm.org/D89041