[libcxx-commits] [PATCH] D88836: [libc++] Fix several debug mode tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added subscribers: libcxx-commits, arphaman, dexonsmith, jkorous.
Herald added a project: libc++.
Herald added a reviewer: libc++.
ldionne requested review of this revision.

These tests were only being run when _LIBCPP_DEBUG was defined, which
isn't the case by default when we run the test suite. In other words,
all these debug mode tests were never being run. This commit makes sure
they are run, and in some cases, extracts them into a file under test/libcxx
to separate them from the Standard tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88836

Files:
  libcxx/test/libcxx/containers/sequences/vector/db_back.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_cback.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_cfront.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_cindex.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_front.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_index.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_iterators_2.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_iterators_3.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_iterators_4.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_iterators_5.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_iterators_6.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/db_iterators_8.pass.cpp
  libcxx/test/libcxx/containers/sequences/vector/pop_back_empty.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/db_bucket.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/db_insert_hint_const_lvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/db_insert_hint_rvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/db_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/db_iterators_8.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/db_local_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/db_local_iterators_8.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/db_move.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_db1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_db2.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db2.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db3.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db4.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.map/unord.map.swap/db_swap_1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/db_insert_hint_const_lvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/db_insert_hint_rvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/db_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/db_iterators_8.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/db_local_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/db_local_iterators_8.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/db_move.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_db1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_db2.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db2.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db3.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db4.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multimap/unord.multimap.swap/db_swap_1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/db_insert_hint_const_lvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/db_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/db_iterators_8.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/db_local_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/db_local_iterators_8.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/db_move.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_db1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_db2.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_iter_db1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_iter_db2.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_iter_db3.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/erase_iter_iter_db4.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.multiset/unord.multiset.swap/db_swap_1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/db_insert_hint_const_lvalue.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/db_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/db_iterators_8.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/db_local_iterators_7.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/db_local_iterators_8.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/db_move.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/erase_iter_db1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/erase_iter_db2.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/erase_iter_iter_db1.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/erase_iter_iter_db2.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/erase_iter_iter_db3.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/erase_iter_iter_db4.pass.cpp
  libcxx/test/libcxx/containers/unord/unord.set/unord.set.swap/db_swap_1.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/db_back.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/db_cback.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/db_cfront.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/db_cindex.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/db_front.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.access/db_index.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_2.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_3.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_4.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_5.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_6.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_7.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_8.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/clear_and_shrink_db1.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_db1.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_db2.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db1.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db2.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db3.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_iter_iter_db4.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/erase_pop_back_db1.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/insert_iter_char_db1.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/insert_iter_iter_iter_db1.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.modifiers/insert_iter_size_char_db1.pass.cpp
  libcxx/test/std/containers/unord/unord.map/bucket.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.cnstr/move.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/erase_iter_db1.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/erase_iter_db2.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db1.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db2.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db3.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/erase_iter_iter_db4.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/insert_hint_const_lvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/insert_hint_rvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.map/unord.map.swap/db_swap_1.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/db_iterators_7.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/db_iterators_8.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/db_local_iterators_7.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/db_local_iterators_8.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.cnstr/move.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_db1.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_db2.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db1.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db2.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db3.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_iter_iter_db4.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/insert_hint_const_lvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/insert_hint_rvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/unord.multimap.swap/db_swap_1.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/db_iterators_7.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/db_iterators_8.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/db_local_iterators_7.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/db_local_iterators_8.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/erase_iter_db1.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/erase_iter_db2.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/erase_iter_iter_db1.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/erase_iter_iter_db2.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/erase_iter_iter_db3.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/erase_iter_iter_db4.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/insert_hint_const_lvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/unord.multiset.cnstr/move.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/unord.multiset.swap/db_swap_1.pass.cpp
  libcxx/test/std/containers/unord/unord.set/db_iterators_7.pass.cpp
  libcxx/test/std/containers/unord/unord.set/db_iterators_8.pass.cpp
  libcxx/test/std/containers/unord/unord.set/db_local_iterators_7.pass.cpp
  libcxx/test/std/containers/unord/unord.set/db_local_iterators_8.pass.cpp
  libcxx/test/std/containers/unord/unord.set/erase_iter_db1.pass.cpp
  libcxx/test/std/containers/unord/unord.set/erase_iter_db2.pass.cpp
  libcxx/test/std/containers/unord/unord.set/erase_iter_iter_db1.pass.cpp
  libcxx/test/std/containers/unord/unord.set/erase_iter_iter_db2.pass.cpp
  libcxx/test/std/containers/unord/unord.set/erase_iter_iter_db3.pass.cpp
  libcxx/test/std/containers/unord/unord.set/erase_iter_iter_db4.pass.cpp
  libcxx/test/std/containers/unord/unord.set/insert_hint_const_lvalue.pass.cpp
  libcxx/test/std/containers/unord/unord.set/unord.set.cnstr/move.pass.cpp
  libcxx/test/std/containers/unord/unord.set/unord.set.swap/db_swap_1.pass.cpp
  libcxx/test/std/strings/basic.string/string.access/db_back.pass.cpp
  libcxx/test/std/strings/basic.string/string.access/db_cback.pass.cpp
  libcxx/test/std/strings/basic.string/string.access/db_cfront.pass.cpp
  libcxx/test/std/strings/basic.string/string.access/db_cindex.pass.cpp
  libcxx/test/std/strings/basic.string/string.access/db_front.pass.cpp
  libcxx/test/std/strings/basic.string/string.access/db_index.pass.cpp
  libcxx/test/std/strings/basic.string/string.iterators/db_iterators_2.pass.cpp
  libcxx/test/std/strings/basic.string/string.iterators/db_iterators_3.pass.cpp
  libcxx/test/std/strings/basic.string/string.iterators/db_iterators_4.pass.cpp
  libcxx/test/std/strings/basic.string/string.iterators/db_iterators_5.pass.cpp
  libcxx/test/std/strings/basic.string/string.iterators/db_iterators_6.pass.cpp
  libcxx/test/std/strings/basic.string/string.iterators/db_iterators_7.pass.cpp
  libcxx/test/std/strings/basic.string/string.iterators/db_iterators_8.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88836.296194.patch
Type: text/x-patch
Size: 93141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201005/2c5a7cf7/attachment-0001.bin>