[libcxx-commits] [PATCH] D87940: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D87940#2322671 <https://reviews.llvm.org/D87940#2322671>, @zibi wrote:

> Removing confusing comment is the only delta.
>
> @ldionne There are plans to have an external buildbot setup on z/OS. I’ll update with more details after discussing with the people trying to figure out the logistics.
>
> As for the `nanosleep()` we would like to keep it upstream it should not be a burden since it's consolidated in one location and clearly guarded for z/OS only. The `nanosleep()` is on our list to implement downstream so the fact we are upstreaming will not minimize our effort to make that function available as part of OS.

If you want to keep `nanosleep()` upstream, please:

1. Put it in a separate header in `src/zos/nanosleep.h` and call the function `nanosleep`
2. Just include the header in `filesystem_common.h`

That way, we won't need the `#if` in the middle of the logic. I might appear overly strict on not adding new `#if`s, but these are the number one thing making libc++'s code complicated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87940/new/

https://reviews.llvm.org/D87940