[libcxx-commits] [PATCH] D87171: Implement P0919R3

Fri Oct 9 12:49:05 PDT 2020

ldionne added a comment.

In D87171#2322353 <https://reviews.llvm.org/D87171#2322353>, @zoecarver wrote:

>> Perhaps my mind is playing tricks to me, but I have the feeling someone else had been working on this before. @zoecarver @curdeius perhaps? In all cases, please do update this revision as we will take it. If someone else had been working on this, we could steal some tests from that other revision if relevant.
>
> Your mind is not playing tricks on you. I implemented this in D59886 <https://reviews.llvm.org/D59886>.
>
> It looks like the main difference between the patches (aside from tests) is that mine relies on a static assertion to prevent "incorrect" use of the new function template overloads whereas yours uses `enable_if`. I think yours is correct because the standard says, "shall not participate in overload resolution".
>
> I'm OK closing the other patch in favor of this one (feel free to look at it or take tests from it if you'd like).

I'm sorry for the duplicate work :-(. It looks like the other patch stopped getting attention at some point.

@rarutyun  Please look at the tests in D59886 <https://reviews.llvm.org/D59886> and take anything that increases the coverage.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87171/new/

https://reviews.llvm.org/D87171