[libcxx-commits] [PATCH] D89041: [libc++] Include <__config_site> from <__config>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added reviewers: EricWF, phosek.
Herald added subscribers: libcxx-commits, dexonsmith, jkorous, mgorny.
Herald added projects: libc++, libc++abi.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.
ldionne requested review of this revision.

Prior to this patch, we would generate a fancy <__config> header by
concatenating <__config_site> and <__config>. This complexifies the
build system and also increases the difference between what's tested
and what's actually installed.

This patch removes that complexity and instead simply installs <__config_site>
alongside the libc++ headers. <__config_site> is then included by <__config>,
which is much simpler.

Doing this also opens the door to having different <__config_site> headers
depending on the target, which was impossible before.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89041

Files:
  libcxx/CMakeLists.txt
  libcxx/docs/TestingLibcxx.rst
  libcxx/include/CMakeLists.txt
  libcxx/include/__config
  libcxx/test/configs/legacy.cfg.in
  libcxx/utils/libcxx/test/config.py
  libcxxabi/src/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89041.296950.patch
Type: text/x-patch
Size: 10331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201008/f3766ebb/attachment-0001.bin>