[libcxx-commits] [PATCH] D88899: [libcxx][executors] Add a --wrapper-command flag to prepend a command

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/utils/run.py:27
     parser.add_argument('--env', type=str, nargs='*', required=False, default=dict())
+    parser.add_argument('--wrapper-command', type=str, required=False, default=None)
     parser.add_argument("command", nargs=argparse.ONE_OR_MORE)
----------------
This is like an executor within an executor. Is there a reason why you don't simply write a separate executor that does the things you need?

I think it would be good to leave these basic executors simple -- the whole thing was meant to be extended by writing new executors, not by making the existing executors more complex.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88899/new/

https://reviews.llvm.org/D88899