[libcxx-commits] [PATCH] D88864: Add assert in `constexpr string_view::operator[]`

Michael Schellenberger Costa via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 6 01:44:06 PDT 2020


miscco accepted this revision.
miscco added a comment.
This revision is now accepted and ready to land.

I wanted to cry at the use of a comma operator, but all the other member functions do the same...

We might want to directly use `__size` rather than `size()` here to avoid the function call in DEBUG mode


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88864/new/

https://reviews.llvm.org/D88864



More information about the libcxx-commits mailing list