[libcxx-commits] [libcxx] e426ae2 - [libcxx][dsl] Fix mutable default argument warning

[Alex Richardson via libcxx-commits]

Author: Alex Richardson
Date: 2020-10-05T23:23:30+01:00
New Revision: e426ae2bd5e04ca57f36bfb64a5a466a6797cea1

URL: https://github.com/llvm/llvm-project/commit/e426ae2bd5e04ca57f36bfb64a5a466a6797cea1
DIFF: https://github.com/llvm/llvm-project/commit/e426ae2bd5e04ca57f36bfb64a5a466a6797cea1.diff

LOG: [libcxx][dsl] Fix mutable default argument warning

This is flagged by PyCharm and can cause subtle bugs. While changing this
also re-sort the imports and add missing ones.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D88816

Added: 
    

Modified: 
    libcxx/utils/libcxx/test/dsl.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/libcxx/test/dsl.py b/libcxx/utils/libcxx/test/dsl.py
index 95d23df7ece1..820a5b341d5d 100644
--- a/libcxx/utils/libcxx/test/dsl.py
+++ b/libcxx/utils/libcxx/test/dsl.py
@@ -6,15 +6,20 @@
 #
 #===----------------------------------------------------------------------===##
 
-import libcxx.test.format
-import lit
-import lit.util
 import os
 import pipes
 import platform
 import re
 import tempfile
 
+import libcxx.test.format
+import lit
+import lit.LitConfig
+import lit.Test
+import lit.TestRunner
+import lit.util
+
+
 def _memoize(f):
   cache = dict()
   def memoized(x):
@@ -83,7 +88,7 @@ def sourceBuilds(config, source):
     _executeScriptInternal(test, ['rm %t.exe'])
     return exitCode == 0
 
-def programOutput(config, program, args=[], testPrefix=''):
+def programOutput(config, program, args=None, testPrefix=''):
   """
   Compiles a program for the test target, run it on the test target and return
   the output.
@@ -92,6 +97,8 @@ def programOutput(config, program, args=[], testPrefix=''):
   execution of the program is done through the %{exec} substitution, which means
   that the program may be run on a remote host depending on what %{exec} does.
   """
+  if args is None:
+    args = []
   with _makeConfigTest(config, testPrefix=testPrefix) as test:
     with open(test.getSourcePath(), 'w') as source:
       source.write(program)