[libcxx-commits] [PATCH] D88843: [libcxx] Don't treat Windows specially with visibility annotations

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

So to be very clear, I'd prefer this not to be committed, as it will break my build setup, and the way for me to work around it isn't very pretty.

A different potential way forward would be to default to not using visibility annotations on windows, making them opt-in instead of opt-out. Because at least in my experience in mingw configurations, mismatches between actual libc++ vs option set in the user's code works much better if the visibility annotations are disabled. IIRC @thieta just ran into the same issue a few weeks ago as well and concluded the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88843/new/

https://reviews.llvm.org/D88843