[libcxx-commits] [PATCH] D88843: [libcxx] Don't treat Windows specially with visibility annotations

[Petr Hosek via Phabricator via libcxx-commits]

phosek created this revision.
phosek added reviewers: smeenai, EricWF, ldionne.
Herald added subscribers: libcxx-commits, dexonsmith, mgorny.
Herald added a project: libc++.
Herald added a reviewer: libc++.
phosek requested review of this revision.

There's no reason to treat Windows specially, users of libc++ can define
_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS just like they would on other
platforms.

See http://lists.llvm.org/pipermail/libcxx-dev/2020-October/000978.html
for more details.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88843

Files:
  libcxx/CMakeLists.txt


Index: libcxx/CMakeLists.txt
===================================================================
--- libcxx/CMakeLists.txt
+++ libcxx/CMakeLists.txt
@@ -855,14 +855,6 @@
   config_define(${abi_defines} _LIBCPP_ABI_DEFINES)
 endif()
 
-# By default libc++ on Windows expects to use a shared library, which requires
-# the headers to use DLL import/export semantics. However when building a
-# static library only we modify the headers to disable DLL import/export.
-if (DEFINED WIN32 AND LIBCXX_ENABLE_STATIC AND NOT LIBCXX_ENABLE_SHARED)
-  message(STATUS "Generating custom __config for non-DLL Windows build")
-  config_define(ON _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS)
-endif()
-
 # Setup all common build flags =================================================
 function(cxx_add_common_build_flags target)
   cxx_add_basic_build_flags(${target})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88843.296250.patch
Type: text/x-patch
Size: 850 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201005/10ee56aa/attachment-0001.bin>