[libcxx-commits] [PATCH] D88727: vector (iterator, iterator) constructor doesn't deduce second arg

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists requested changes to this revision.
mclow.lists added inline comments.


================
Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter_alloc.pass.cpp:97
+    test<std::vector<int> >({}, input_iterator<const int*>{});
+    test<std::vector<int> >({}, forward_iterator<const int*>{});
+
----------------
You should test both combinations.

```
    test<std::vector<int> >(input_iterator<const int*>{}, {});
    test<std::vector<int> >(forward_iterator<const int*>{}, {});
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88727/new/

https://reviews.llvm.org/D88727