[libcxx-commits] [PATCH] D88454: [CMake] Use -isystem flag to access libc++ headers

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D88454#2307806 <https://reviews.llvm.org/D88454#2307806>, @uabelho wrote:

> Hi!
> I don't understand why, but with this commit I start seeing several warnings like this when compiling builtins:
>
>   /data/repo/master/compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.h:45:7: error: '__sanitizer::FlagHandler<bool>' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
>   class FlagHandler : public FlagHandlerBase {
>         ^
>   /data/repo/master/compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.h:71:13: note: in instantiation of template class '__sanitizer::FlagHandler<bool>' requested here
>   inline bool FlagHandler<bool>::Parse(const char *value) {
>               ^

That's a bit surprising. What's your build configuration? Do you use runtimes build? I haven't managed to reproduce it locally so far.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88454/new/

https://reviews.llvm.org/D88454