[libcxx-commits] [PATCH] D88650: [libc++][ci] Add a configuration testing Apple's system library build

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added subscribers: libcxx-commits, dexonsmith, jkorous.
Herald added a project: libc++.
Herald added a reviewer: libc++.
ldionne requested review of this revision.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88650

Files:
  libcxx/utils/ci/buildkite-pipeline.yml
  libcxx/utils/ci/run-buildbot.sh


Index: libcxx/utils/ci/run-buildbot.sh
===================================================================
--- libcxx/utils/ci/run-buildbot.sh
+++ libcxx/utils/ci/run-buildbot.sh
@@ -10,6 +10,8 @@
 set -ex
 
 BUILDER="${1}"
+MONOREPO_ROOT="$(git rev-parse --show-toplevel)"
+BUILD_DIR="${MONOREPO_ROOT}/build/${BUILDER}"
 
 args=()
 args+=("-DLLVM_ENABLE_PROJECTS=libcxx;libunwind;libcxxabi")
@@ -100,19 +102,29 @@
     args+=("-DLIBCXXABI_ENABLE_THREADS=OFF")
     args+=("-DLIBCXX_ENABLE_MONOTONIC_CLOCK=OFF")
 ;;
+x86_64-apple-system)
+    export CC=clang
+    export CXX=clang++
+    args+=("-DLLVM_LIT_ARGS=-sv --show-unsupported")
+    args+=("-C${MONOREPO_ROOT}/libcxx/cmake/caches/Apple.cmake")
+;;
+x86_64-apple-system-noexceptions)
+    export CC=clang
+    export CXX=clang++
+    args+=("-DLLVM_LIT_ARGS=-sv --show-unsupported")
+    args+=("-C${MONOREPO_ROOT}/libcxx/cmake/caches/Apple.cmake")
+    args+=("-DLIBCXX_ENABLE_EXCEPTIONS=OFF")
+    args+=("-DLIBCXXABI_ENABLE_EXCEPTIONS=OFF")
+;;
 *)
     echo "${BUILDER} is not a known configuration"
     exit 1
 ;;
 esac
 
-UMBRELLA_ROOT="$(git rev-parse --show-toplevel)"
-LLVM_ROOT="${UMBRELLA_ROOT}/llvm"
-BUILD_DIR="${UMBRELLA_ROOT}/build/${BUILDER}"
-
 echo "--- Generating CMake"
 rm -rf "${BUILD_DIR}"
-cmake -S "${LLVM_ROOT}" -B "${BUILD_DIR}" -GNinja -DCMAKE_BUILD_TYPE=RelWithDebInfo "${args[@]}"
+cmake -S "${MONOREPO_ROOT}/llvm" -B "${BUILD_DIR}" -GNinja -DCMAKE_BUILD_TYPE=RelWithDebInfo "${args[@]}"
 
 echo "--- Building libc++ and libc++abi"
 ninja -C "${BUILD_DIR}" check-cxx-deps cxxabi
Index: libcxx/utils/ci/buildkite-pipeline.yml
===================================================================
--- libcxx/utils/ci/buildkite-pipeline.yml
+++ libcxx/utils/ci/buildkite-pipeline.yml
@@ -74,3 +74,13 @@
     command: "set -o pipefail && libcxx/utils/ci/run-buildbot.sh x86_64-ubuntu-singlethreaded | libcxx/utils/ci/phabricator-report"
     agents:
       queue: "libcxx-builders"
+
+  # Build with the configuration we use to generate libc++.dylib on Apple platforms
+  - label: "Apple system"
+    command: "set -o pipefail && libcxx/utils/ci/run-buildbot.sh x86_64-apple-system | libcxx/utils/ci/phabricator-report"
+    agents:
+      queue: "libcxx-macos-builders"
+  - label: "Apple system -fno-exceptions"
+    command: "set -o pipefail && libcxx/utils/ci/run-buildbot.sh x86_64-apple-system-noexceptions | libcxx/utils/ci/phabricator-report"
+    agents:
+      queue: "libcxx-macos-builders"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88650.295542.patch
Type: text/x-patch
Size: 2485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201001/691c9cc6/attachment.bin>