[libcxx-commits] [PATCH] D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

> Could you elaborate / invent artificial scenario when such logic is necessary?

I don't have to invent any such logic. It's right there in the existing code.

and if "and it is standardized", that's a moot point.  The question is "what is the most useful way for libc++"?

And I believe that using  `_LIBCPP_NO_HAS_CHAR8_T`, like it does with `_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER`, `_LIBCPP_HAS_NO_LONG_LONG`, `_LIBCPP_HAS_NO_NULLPTR`, `_LIBCPP_HAS_NO_AUTO_TYPE`, `_LIBCPP_HAS_NO_CXX14_CONSTEXPR`, `_LIBCPP_HAS_NO_VARIABLE_TEMPLATES`, `_LIBCPP_HAS_NO_NOEXCEPT`, `_LIBCPP_HAS_NO_ASAN`, `_LIBCPP_HAS_NO_CXX20_CHRONO_LITERALS`, `_LIBCPP_HAS_NO_CXX14_CONSTEXPR`, `_LIBCPP_HAS_NO_VARIABLE_TEMPLATES`, `_LIBCPP_HAS_NO_ASAN`, `_LIBCPP_HAS_NO_CXX14_CONSTEXPR`, `_LIBCPP_HAS_NO_VARIABLE_TEMPLATES`, `_LIBCPP_HAS_NO_ASAN`, `_LIBCPP_HAS_NO_VECTOR_EXTENSION`, `_LIBCPP_HAS_NO_UNICODE_CHARS`, `_LIBCPP_HAS_NO_VARIABLE_TEMPLATES`, `_LIBCPP_HAS_NO_ASAN`, `_LIBCPP_HAS_NO_VECTOR_EXTENSION`, `_LIBCPP_HAS_NO_INT128`, `_LIBCPP_HAS_NO_LIBRARY_ALIGNED_ALLOCATION`, `_LIBCPP_HAS_NO_LIBRARY_ALIGNED_ALLOCATION`, `_LIBCPP_HAS_NO_LIBRARY_ALIGNED_ALLOCATION`, `_LIBCPP_HAS_NO_GLOBAL_FILESYSTEM_NAMESPACE`, `_LIBCPP_HAS_NO_STDIN`, `_LIBCPP_HAS_NO_STDOUT`, `_LIBCPP_HAS_NO_THREAD_UNSAFE_C_FUNCTIONS`, `_LIBCPP_HAS_NO_ATOMIC_HEADER`, `_LIBCPP_HAS_NO_BUILTIN_ADDRESSOF`, `_LIBCPP_HAS_NO_BUILTIN_IS_CONSTANT_EVALUATED`, `_LIBCPP_HAS_NO_OFF_T_FUNCTIONS`, `_LIBCPP_HAS_NO_DEDUCTION_GUIDES`, `_LIBCPP_HAS_NO_IS_AGGREGATE`, `_LIBCPP_HAS_NO_COROUTINES`, `_LIBCPP_HAS_NO_SPACESHIP_OPERATOR`, `_LIBCPP_HAS_NO_PRAGMA_PUSH_POP_MACRO`, `_LIBCPP_HAS_NO_FGETPOS_FSETPOS` (and others).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92212/new/

https://reviews.llvm.org/D92212