[libcxx-commits] [PATCH] D92229: [libc++] Update clang-format configuration

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks @curdeius for looking into this! The lack of proper clang-format rules for libc++ also bothered me a bit. Ut didn't bother me enough to look into it yet.

I also prefer to use automatic formatting as much as possible. If clang-format has things it doesn't format well, we might want to ask the clang-format devs so they can improve it. Then we can use the automatic formatting after the next release. That would benefit us and the other users of clang-format.

I prefer to have one commit to format everything, then we only need to blacklist one commit in the blame list. I would at least prefer to do all code in `include` and `src` in one commit. I don't have a preference whether we should also do the unit tests and benchmarks in one go or fix them when the files are touched.

I don't have a strong preference on which clang-format rules we use. However I think we should decide on the clang-format rules before formatting the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92229/new/

https://reviews.llvm.org/D92229