[libcxx-commits] [PATCH] D92190: [libc++] fix std::sort(T**, T**)

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 27 09:59:56 PST 2020


ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp:138
+{
+    const int array_size = 10;
+    const int v[array_size] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9};
----------------
curdeius wrote:
> It would be standard C++ this way not requiring any extensions (dynamic array), nope?
You're right. @bfg please do what Marek suggests or what I suggested. It doesn't matter to me, as long as we're standard c++03.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92190/new/

https://reviews.llvm.org/D92190



More information about the libcxx-commits mailing list