[libcxx-commits] [PATCH] D91517: [libc++] [P0482] [C++20] Implement missing bits for codecvt and codecvt_byname.

Fri Nov 27 08:05:48 PST 2020

curdeius added a comment.

In D91517#2420181 <https://reviews.llvm.org/D91517#2420181>, @ldionne wrote:

> In D91517#2419547 <https://reviews.llvm.org/D91517#2419547>, @curdeius wrote:
>
>> Ok. Will wait for your patch. I just added XFAIL for macosx dylibs.
>
> Can you confirm that the issues you were seeing on older macOSes are that the tests are now exercising `char8_t` `codecvt`, so you're seeing runtime errors since those are not `install`ed in older dylibs? I'm trying to make sure we understand the issue and don't silent something important.

Yes, all the 33 test failures in https://buildkite.com/llvm-project/libcxx-ci/builds/578#4979bae1-6f90-4d3a-a17e-9b9981aaedbf
were due to missing symbols, e.g.:

  dyld: Symbol not found: __ZNKSt3__17codecvtIDiDu11__mbstate_tE10do_unshiftERS1_PDuS4_RS4_
    Referenced from: /private/tmp/buildkite-agent/builds/libcxx-mbp-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-backdeployment-10.9/projects/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt.byname/Output/ctor_char32_t_char8_t.pass.cpp.dir/t.tmp.exe
    Expected in: /private/tmp/buildkite-agent/builds/libcxx-mbp-local-1/llvm-project/libcxx-ci/build/x86_64-apple-system-backdeployment-10.9/macos-roots/macOS/libc++/10.9/libc++.1.dylib

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91517/new/

https://reviews.llvm.org/D91517