[libcxx-commits] [PATCH] D92229: [libc++] Update clang-format configuration

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 27 07:21:50 PST 2020


ldionne added a comment.

In D92229#2420176 <https://reviews.llvm.org/D92229#2420176>, @miscco wrote:

> I really like that we get clang-format to work. Live is simply to short to worry about formatting.
>
> I assume we should simply make one monster commit adding that to the exception list for git blame and be done with it

That would still make it more difficult to blame stuff if lines move around a lot. Another option would be to mandate that we clang-format everything we touch from now on. Thus, as we make changes to the library, the lines we change (and some amount of surrounding context) would be re-formatted. I'm not sure which approach is best, since I haven't done it before. I'd be curious to hear stories of folks who moved existing codebases to Clang format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92229/new/

https://reviews.llvm.org/D92229



More information about the libcxx-commits mailing list