[libcxx-commits] [PATCH] D92214: [libc++] Implement format_error.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 27 03:11:23 PST 2020


Mordante planned changes to this revision.
Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review!

It seems a build bot fails. I'll investigate this further.



================
Comment at: libcxx/include/format:231
+public:
+  _LIBCPP_INLINE_VISIBILITY explicit format_error(const string& __s)
+      : runtime_error(__s) {}
----------------
miscco wrote:
> It pains me to see this in C++20 feature 
I agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92214/new/

https://reviews.llvm.org/D92214



More information about the libcxx-commits mailing list