[libcxx-commits] [PATCH] D92194: [libc++] Formalize what configurations are covered by the ABI lists

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 26 12:32:34 PST 2020


ldionne created this revision.
Herald added subscribers: libcxx-commits, jfb, jkorous, arichardson, mgorny.
Herald added a project: libc++.
Herald added a reviewer: libc++.
ldionne requested review of this revision.

By encoding ABI-affecting properties in the name of the ABI list, it
makes it clear when an ABI list test should or should not be available,
and what results we should expect.

Note that we clearly don't encode all ABI-affecting parameters in the
name right now -- I just ported over what we supported in the code that
was there previously. As we encounter configurations that we wish to
support but produce different ABI lists, we can add those to the ABI
identifier and start supporting them.

This commit also starts checking the ABI list in the CI jobs that run
a supported configuration. Eventually, all configurations should have
a generated ABI list and the test should even run implicitly as part of
the Lit test suite.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92194

Files:
  libcxx/lib/abi/CMakeLists.txt
  libcxx/lib/abi/x86_64-apple-darwin.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist
  libcxx/lib/abi/x86_64-apple-darwin.v1.abilist
  libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist
  libcxx/lib/abi/x86_64-unknown-linux-gnu.v1.abilist
  libcxx/utils/ci/run-buildbot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92194.307913.patch
Type: text/x-patch
Size: 460020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201126/ba66edd0/attachment-0001.bin>


More information about the libcxx-commits mailing list