[libcxx-commits] [PATCH] D92190: [libc++] fix std::sort(T**, T**)

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 26 10:47:51 PST 2020


arichardson added a comment.

In D92190#2418963 <https://reviews.llvm.org/D92190#2418963>, @ldionne wrote:

> Oh, and I agree with Marshall -- if there's a bug report for this, please link it from the test and mention it in the commit message.

I just looked at our bugtrackers and I don't think we ever filed this as an issue. The problem was noticed when running jsc (the command line tool from WebKit to run JavaScript code).
In memory our pointers (CHERI capabilities) looks like pairs of "64-bit address+64 bits of metadata (permissions+bounds)", so after calling std::sort we ended up with an array containing just the addresses of the pointers, followed by the sorted virtual addresses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92190/new/

https://reviews.llvm.org/D92190



More information about the libcxx-commits mailing list