[libcxx-commits] [PATCH] D91311: Add new 'preferred_name' attribute.

Richard Smith - zygoloid via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 25 15:11:04 PST 2020


rsmith added a comment.

In D91311#2416940 <https://reviews.llvm.org/D91311#2416940>, @ldionne wrote:

> LGTM from the libc++ point of view. The CI is passing -- those failures are flaky modules tests that we need to fix.

Perhaps we need to specify `-fmodules-validate-system-headers` in the test so Clang doesn't assume that system headers are unchanged?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91311/new/

https://reviews.llvm.org/D91311



More information about the libcxx-commits mailing list