[libcxx-commits] [PATCH] D91981: [libc++] Remove _LIBCPP_CONSTEXPR_AFTER_CXX17_WITH_IS_CONSTANT_EVALUATED

Tue Nov 24 07:18:20 PST 2020

ldionne added inline comments.

================
Comment at: libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.wchar.t/move.pass.cpp:42

-#if TEST_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_BUILTIN_IS_CONSTANT_EVALUATED)
+#if TEST_STD_VER > 17
   static_assert(test());
----------------
Quuxplusone wrote:
> (commenting here just so we get nice comment threading)
> 
> > Note that we don't have clang-8 bots in the pre-commit CI.
> > I do expect this is going to break some tests on slightly older compilers, so we should add some UNSUPPORTED markup. I think we can check this in, keep an eye on the post-commit Buildbots and see if anything fails, and then fix it quickly if so.
> 
> Aw, phooey. @ldionne, do you think it would make sense to preemptively `// UNSUPPORTED: clang-8` on these `char_traits` tests I'm changing?
> 
> If you're //expecting// buildbot breakage, which likely @ldionne will be the one to fix and Arthur won't, then I suggest that @ldionne should be the one to land this patch. Or else Slack me so that we can both be paying attention at the same time. I just don't want to land it right before you go to sleep or something.
Let's add `UNSUPPORTED` markup first. Then ping me on Slack and we'll land it. There shouldn't be failures because of the markup, but who knows.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91981/new/

https://reviews.llvm.org/D91981