[libcxx-commits] [PATCH] D91981: [libc++] Remove _LIBCPP_CONSTEXPR_AFTER_CXX17_WITH_IS_CONSTANT_EVALUATED

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 23 13:39:03 PST 2020


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This LGTM. I do expect this is going to break some tests on slightly older compilers, so we should add some `UNSUPPORTED` markup. I think we can check this in, keep an eye on the post-commit Buildbots and see if anything fails, and then fix it quickly if so.

LGTM once the pre-commit CI passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91981/new/

https://reviews.llvm.org/D91981



More information about the libcxx-commits mailing list