[libcxx-commits] [PATCH] D91986: [libc++] Implements concept constructible_from

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 23 12:11:57 PST 2020


cjdb added a comment.

@CaseyCarter had this to say back in D74291 <https://reviews.llvm.org/D74291>.

> There's tons of coverage here for class types and reference types. What about `void`, function types, pointers, arrays, pointers-to-members? (I don't know about clang/libc++, but the MSVC STL tests for type traits tend to _be_ the tests for compiler intrinsics used to implement those traits, so we consequently cover everything under the sun.)

I'd suggest we apply this here as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91986/new/

https://reviews.llvm.org/D91986



More information about the libcxx-commits mailing list