[libcxx-commits] [PATCH] D90228: [libcxx] Don't truncate intermediates to wchar_t when widening
Mikhail Goncharov via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Nov 23 08:38:46 PST 2020
goncharov added a comment.
In D90228#2357218 <https://reviews.llvm.org/D90228#2357218>, @ldionne wrote:
> CI doesn't trigger a second time -- maybe it's because the diff hasn't changed, or because the revision was accepted. @goncharov Do you know?
Yes, in some cases revisions do not trigger herald rules at all (like this one) or have not repository set. I believe that individual configuration or how one uploads diff can cause that.
@mstorsjo have you used "arc" to create the second diff (rebased one)? Have you set any config parameters of it that might affect this?
> In all cases, please feel free to ship it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90228/new/
https://reviews.llvm.org/D90228
More information about the libcxx-commits
mailing list