[libcxx-commits] [PATCH] D91778: [libc++] [C++20] [P0966] Fix bug PR45368 by correctly implementing P0966: string::reserve should not shrink.

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 23 03:12:16 PST 2020


curdeius added a comment.

Ready for review!
On BuildKite there are some failures on Apple, but 3/4 concern `libcxx/modules/stds_include.sh.cpp` which seems (very) flaky.
The fourth one (on `Apple back-deployment macosx10.9`) looks severe, but I suspect that it doesn't compile `src/` with `-std=c++20` flag, and so uses instantiation of `basic_string<char>` as of C++17.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91778/new/

https://reviews.llvm.org/D91778



More information about the libcxx-commits mailing list