[libcxx-commits] [PATCH] D88818: [libc++] Add missing XFAIL to tests that need __atomic_* libcalls

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Nov 21 04:39:33 PST 2020


arichardson updated this revision to Diff 306837.
arichardson edited the summary of this revision.
arichardson added a comment.
Herald added a reviewer: jfb.

Rebase on top of D91911 <https://reviews.llvm.org/D91911> and remove the #ifndef __APPLE__ special case from atomic_helpers.

The CI was failing because the non-lockfree-atomics was being detected as false on Apple platforms due to missing __atomic_is_lockfree even though the other ones were available.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88818/new/

https://reviews.llvm.org/D88818

Files:
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_compare_exchange_strong.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_compare_exchange_strong_explicit.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_compare_exchange_weak.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_compare_exchange_weak_explicit.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_exchange.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_exchange_explicit.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_helpers.h
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_init.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_is_lock_free.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_load.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_load_explicit.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_store.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/atomic_store_explicit.pass.cpp
  libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_wait.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88818.306837.patch
Type: text/x-patch
Size: 9155 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201121/19186679/attachment-0001.bin>


More information about the libcxx-commits mailing list