[libcxx-commits] [PATCH] D91349: [libc++] hash<long double>: adjust for x86-64 ILP32

[Harald van Dijk via Phabricator via libcxx-commits]

hvdijk added a comment.

In D91349#2408723 <https://reviews.llvm.org/D91349#2408723>, @ldionne wrote:

> That looks correct to me with what I just read about x32 (I wasn't familiar with it). I can't imagine this is the only place that needs fixing for libc++ to work in x32?

It's the only place in libc++ that needs fixing in order to get the test suite to pass. Beyond that, I am not sure, as there are some issues on the LLVM and clang side as well that prevent more extensive testing. I am trying to address those as well, and may be able to try a system rebuild with clang+libc++ after that to hopefully catch any remaining issues.

> If you need me to commit this, please provide `Author Name <email at domain>`.

Thanks! Could you commit this under 'Harald van Dijk <harald at gigawatt.nl>'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91349/new/

https://reviews.llvm.org/D91349