[libcxx-commits] [PATCH] D89495: [libc++] Use the internal Lit shell to run the tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/libcxx/selftest/shell-escape.sh.cpp:18
-
-// RUN: ! false
----------------
arichardson wrote:
> Is this change required because the internal shell doesn't support `!`?
> 
> It might be useful to add `!` support to the integrated shell, as that would allow avoiding some process spawns for the `not` utility.
Yes, that's correct. I implemented `not` as a shell builtin in https://reviews.llvm.org/D89493.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89495/new/

https://reviews.llvm.org/D89495