[libcxx-commits] [PATCH] D91574: [libc++] Simplify how we pick the typeinfo comparison

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D91574#2404957 <https://reviews.llvm.org/D91574#2404957>, @fhahn wrote:

> In D91574#2404708 <https://reviews.llvm.org/D91574#2404708>, @lebedev.ri wrote:
>
>> This seems to have broken no-op rebuild w/ existing build dir:
>>
>>   CMake Error at /repositories/llvm-project/libcxx/CMakeLists.txt:187 (message):
>>     Value '' is not a valid value for
>>   
>>                            LIBCXX_TYPEINFO_COMPARISON_IMPLEMENTATION
>>   
>>   
>>   -- Configuring incomplete, errors occurred!
>>
>> It seems to work after i manually specify `-DLIBCXX_TYPEINFO_COMPARISON_IMPLEMENTATION=default`, but still..
>
> Same for me.
>
> @ldionne would it be possible to adjust the default so that it doesn't break re-builds & works without explicitly having to set `DLIBCXX_TYPEINFO_COMPARISON_IMPLEMENTATION`?

Sorry, but no. The whole point of this patch is partly to make the default explicit. We've had bugs related to defining this as an empty string (which it was previously), which is what would appear to "satisfy" rebuilds.

I already said the bug was that these bots are not cleaning their build directory (or at least their build cache), and I stand by that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91574/new/

https://reviews.llvm.org/D91574