[libcxx-commits] [PATCH] D91708: [libcxx] Add some missing _VSTD:: to <vector>, with a regression test.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

In D91708#2404126 <https://reviews.llvm.org/D91708#2404126>, @Quuxplusone wrote:

> Sorry, @ldionne, I've got a better test now, and more proposed _VSTDs!
>
> I hacked my local "test_allocator.h" to use this "AdlTrap" trick, and discovered a few more places where ADL calls were being made. I don't propose to commit the test_allocator stuff, because a container using such an allocator breaks //all// ADL calls, including simple stuff like `vec1 == vec2`. But it was a fun experiment!
>
> I have this as three commits locally; should I land them as three commits, or as one commit?

As you wish. If it were me I might squash them since they are strongly related, but it's as you see fit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91708/new/

https://reviews.llvm.org/D91708