[libcxx-commits] [PATCH] D91574: [libc++] Simplify how we pick the typeinfo comparison

[Roman Lebedev via Phabricator via libcxx-commits]

lebedev.ri added a comment.

This seems to have broken no-op rebuild w/ existing build dir:

  CMake Error at /repositories/llvm-project/libcxx/CMakeLists.txt:187 (message):
    Value '' is not a valid value for
  
                           LIBCXX_TYPEINFO_COMPARISON_IMPLEMENTATION
  
  
  -- Configuring incomplete, errors occurred!

It seems to work after i manually specify `-DLIBCXX_TYPEINFO_COMPARISON_IMPLEMENTATION=default`, but still..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91574/new/

https://reviews.llvm.org/D91574