[libcxx-commits] [PATCH] D91311: Add new 'preferred_name' attribute.

Wed Nov 18 13:37:31 PST 2020

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Actually, apologies -- I might have accepted this too quickly.

We can stick with this design, but I'd like to understand why `#if _LIBCPP_HAS_NO_PREFERRED_NAME` is necessary in `<iosfwd>`, and also the CI is failing on MacOS.

================
Comment at: libcxx/include/iosfwd:188

+#ifdef _LIBCPP_PREFERRED_NAME
+template <class _CharT, class _Traits>
----------------
rsmith wrote:
> aaron.ballman wrote:
> > We always define `_LIBCPP_PREFERRED_NAME` so is this actually needed?
> Thanks, I was trying to avoid the redundant redeclarations when the attribute is unavailable, but clearly this doesn't do that! Fixed.
Is that really needed? What's the issue with having redundant declarations?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91311/new/

https://reviews.llvm.org/D91311