[libcxx-commits] [PATCH] D91662: Revert switch-based std::variant implementation again.

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 17 14:44:58 PST 2020


EricWF created this revision.
EricWF added a reviewer: ldionne.
EricWF added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.
EricWF requested review of this revision.

These changes cause substantial binary size increases for non-opt builds.
For example, the visit.pass.cpp test grows from 20k to 420k.

Further work will be done to re-land this patch without the size increases,
but that work is proving too tricky to fix forward.

The changes this patch reverts are:

- 35d226911165a9aae1f01f521a0019f1a9c0a25f <https://reviews.llvm.org/rG35d226911165a9aae1f01f521a0019f1a9c0a25f>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91662

Files:
  libcxx/include/variant

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91662.305908.patch
Type: text/x-patch
Size: 22234 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201117/22515874/attachment-0001.bin>


More information about the libcxx-commits mailing list